feat: ContentHero design update #16032
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wackerow
requested review from
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
5 tasks
pettinarip
reviewed
Aug 18, 2025
There was a problem hiding this comment.
@wackerow looks good, left a question about the hero image dimensions
| @@ -73,7 +73,7 @@ export const UpgradeLayout = ({ | |||
| const heroProps = { | |||
| ...frontmatter, | |||
| breadcrumbs: { slug, startDepth: 1 }, | |||
| heroImg: frontmatter.image, | |||
| heroImg: { src: frontmatter.image, width: 5750, height: 4332 }, | |||
There was a problem hiding this comment.
I'm a bit unsure about this pattern and whether it's truly needed.
For dynamic images, I assume we'll need to pass width and height for aspect ratio. If so, I'd define these in the ContentHero component, as all images there will likely require consistent dimensions.
Comment on lines
-24
to
-25
| width={760} | ||
| height={451} |
There was a problem hiding this comment.
shouldn't we keep these dimensions to keep the same aspect ratio or a calculated width & height to avoid layout shifts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates ContentHero according to new /what-is-ethereum designs
Preview links
Layer 2 pages
Roadmap layout
Staking layout
Translatathon layout
Upgrade layout
Use cases layout